Closed Gallaecio closed 7 months ago
Merging #79 (57080d2) into main (56e9709) will not change coverage. The diff coverage is
0.00%
.:exclamation: Current head 57080d2 differs from pull request most recent head 036cc71. Consider uploading reports for the commit 036cc71 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@wRAR After I created this PR, I thought came to me: Could it be more helpful to raise an exception that indicates the (unsupported) type of node received rather than silently ignoring it? The current PR could lead a developer to believe that things do not work (e.g. due to some bug), rather than they are passing the wrong selector. Specially since it might not be obvious that we are only picking the first selector of a SelectorList
(which I am now wondering if it is the right approach for description processors).
Not 100% sure but it looks better to throw an exception, yeah.
Reported by @seagatesoft.