Closed PyExplorer closed 6 months ago
@PyExplorer make sure to setup pre-commit, as described in https://zyte-common-items.readthedocs.io/en/latest/contributing.html
@kmike How do you feel about depending on scrapy
? I know we have tried to avoid that in the past. Should we keep it as an optional dependency? (and copy the load_object
code)
Merging #91 (e3e90b7) into main (8c37eed) will not change coverage. Report is 31 commits behind head on main. The diff coverage is
0.00%
.:exclamation: Current head e3e90b7 differs from pull request most recent head cee7c86. Consider uploading reports for the commit cee7c86 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Thanks a mil @kmike for the final detailed reviews and valuable suggestions. Agree, that using mock approach in such projects is probably not the best choice, and I will definitely include rewriting tests for this pipeline here in my plans.
This pipeline was implemented during the work on
zyte-spider-templates
and it was decided to move it to this repository as a general solution for dropping items with low probability.