Closed Nykakin closed 1 month ago
Overall, 👍, much needed changes. Having e.g. an images processor is a must.
Attention: Patch coverage is 0%
with 45 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
cce3b94
) to head (30baf8a
). Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
zyte_common_items/processors.py | 0.00% | 43 Missing :warning: |
zyte_common_items/pages/product.py | 0.00% | 2 Missing :warning: |
In response to https://github.com/zytedata/zyte-common-items/pull/99#discussion_r1725091519 and after some discussion in slack I've decided to just return strings without any change in price_processor
instead of parsing it, thus retaining original philosophy of transparent processors.
The discussion about this approach can continue but I do not want to block image processors and brand processor because of it.
Thanks @Nykakin!
We'd like to remove processors from our utils and replace them with
zyte-common-items
counterparts. There are some functionality missing, however.Summary of changes:
images_processor
, that attempts to convert input to list ofzyte_common_items.Image
instancesbrand_processor
returnzyte_common_items.Brand
instances instead of stringsbrand_processor
to take string as an input argumentprice_processor
to takestring ornumber as input argument (resolves https://github.com/zytedata/zyte-common-items/issues/94)