search

zyxist / chainsaw

Gradle plugin: adds support for building Java 9 modules.
Apache License 2.0
71 stars 4 forks source link

Support for --add-modules generally #32

Open Vampire opened 6 years ago

Vampire commented 6 years ago

Please support specifying additional modules that are added with --add-modules via JavaModuleHacks and not only for extra test modules.

Of course you could also just requires them in your module descriptor, but I'd consider that even hackier than via the JavaModuleHacks, as your module does not actually require the given module. One example is netty with a JRE runtime that was produced with javapackager. If you use it with a full JRE all works fine, if you use it with the "custom" JRE runtime, you get a class not found exception for sun.misc.Unsafe unless you either require jdk.unsupported in your own module descriptor or use --add-modules jdk.unsupported.

Vampire commented 6 years ago

Other examples are async.http.client which needs org.slf4j or com.fasterxml.jackson.databind and jasperreports which need java.sql.