Closed cormacrelf closed 6 years ago
@cormacrelf you're right. And thank you for the PR, however I prefer to put is as peerDependencies just for informative purpose (react-dnd seems to went far since)
Mate! Close but no cigar. It would be fine to peerDepend on dnd-core
, but requiring react-dnd
just brings us back to square one for angular-skyhook
.
Ah ok, didn't get you the first time. I'll fix that in next release
Brilliant, thank you!
I'm the author of angular-skyhook, which is a re-implementation of
react-dnd
in Angular. It uses the same underlyingdnd-core
and is therefore compatible with all the backends.The only problem is that existing backends tend to depend on
react-dnd
, and by extension,react
. Technically, backends don't need any dependencies, but apeerDependency
ondnd-core
would be appropriate if you wanted to, and useful if it ever adds type annotations. Browsing this codebase, it seems like the only use ofreact-dnd
is for the examples, which means the only work to do is change how the examples refer to the backend. You could probably just find and replace to make all references start with../../
or something.I'm happy to submit a PR to that effect.
Related issues