zz-jason / leanstore

LeanStore is a larger-than-memory database, optimized for NVMe SSD and multi-core CPU, achieves performance close to in-memory systems without having to keep all data in memory.
MIT License
20 stars 2 forks source link

fix: correct gc tombstone to graveyard #41

Closed zz-jason closed 7 months ago

zz-jason commented 7 months ago

I added a flag enable_eager_garbage_collection for eager GC after each transaction commit to check whether tombstones of removed tuples are deleted or moved to the graveyard as expected.

Ref to Scalable and Robust Snapshot Isolation for High-Performance Storage Engines

codecov[bot] commented 7 months ago

Codecov Report

Attention: 230 lines in your changes are missing coverage. Please review.

Comparison is base (80a74e9) 34.47% compared to head (fbee343) 35.34%.

Files Patch % Lines
source/concurrency-recovery/ConcurrencyControl.cpp 37.50% 10 Missing and 75 partials :warning:
source/storage/btree/TransactionKV.cpp 9.67% 54 Missing and 30 partials :warning:
source/concurrency-recovery/HistoryTree.cpp 40.00% 2 Missing and 13 partials :warning:
source/storage/buffer-manager/TreeRegistry.hpp 26.31% 7 Missing and 7 partials :warning:
source/utils/RandomGenerator.hpp 40.00% 3 Missing and 6 partials :warning:
source/LeanStore.cpp 22.22% 0 Missing and 7 partials :warning:
source/concurrency-recovery/Worker.cpp 53.84% 1 Missing and 5 partials :warning:
source/concurrency-recovery/CRMG.cpp 62.50% 2 Missing and 1 partial :warning:
source/storage/buffer-manager/BufferManager.cpp 40.00% 2 Missing and 1 partial :warning:
...rce/storage/buffer-manager/BufferFrameProvider.hpp 0.00% 1 Missing and 1 partial :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #41 +/- ## ========================================== + Coverage 34.47% 35.34% +0.86% ========================================== Files 85 85 Lines 7619 7713 +94 Branches 3608 3706 +98 ========================================== + Hits 2627 2726 +99 + Misses 3419 3286 -133 - Partials 1573 1701 +128 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.