zz1000zz / OCTGN_TF

OCTGN Patch for the Transformers TCG
2 stars 2 forks source link

Error when moving characters #25

Closed hen closed 4 years ago

hen commented 4 years ago

Here's the error when you move a character. I get it when using Play Characters, and then subsequently moving them.

Hitting Play Characters for this:

https://github.com/hen/Decks/blob/master/Jank/OneShallSmash.o8d

Traceback (most recent call last): File "", line 1, in File "C:\Users\hen\AppData\Local\Programs\OCTGN\Data\GameDatabase\f44befce-4d6d-4fb9-a286-9585f36aece9\scripts\actions.py", line 504, in onCardsMoved File "", line 297, in name SystemError: Object reference not set to an instance of an object.

onCardsMoved(EventArgument({"player":Player(1), "cards":[Card(65606)], "fromGroups":[Pile(16842756, 'Characters', Player(1))], "toGroups":[table], "indexs":[0], "xs":[0], "ys":[0], "highlights":["None"], "markers":["{}"], "faceups":[True], "filters":["None"], "alternates":[""]})) Traceback (most recent call last): File "", line 1, in File "C:\Users\hen\AppData\Local\Programs\OCTGN\Data\GameDatabase\f44befce-4d6d-4fb9-a286-9585f36aece9\scripts\actions.py", line 504, in onCardsMoved File "", line 297, in name SystemError: Object reference not set to an instance of an object.

onCardsMoved(EventArgument({"player":Player(1), "cards":[Card(65607)], "fromGroups":[Pile(16842756, 'Characters', Player(1))], "toGroups":[table], "indexs":[0], "xs":[0], "ys":[0], "highlights":["None"], "markers":["{}"], "faceups":[True], "filters":["None"], "alternates":[""]})) Traceback (most recent call last): File "", line 1, in File "C:\Users\hen\AppData\Local\Programs\OCTGN\Data\GameDatabase\f44befce-4d6d-4fb9-a286-9585f36aece9\scripts\actions.py", line 504, in onCardsMoved File "", line 297, in name SystemError: Object reference not set to an instance of an object.

onCardsMoved(EventArgument({"player":Player(1), "cards":[Card(65608)], "fromGroups":[Pile(16842756, 'Characters', Player(1))], "toGroups":[table], "indexs":[0], "xs":[0], "ys":[0], "highlights":["None"], "markers":["{}"], "faceups":[True], "filters":["None"], "alternates":[""]})) Traceback (most recent call last): File "", line 1, in File "C:\Users\hen\AppData\Local\Programs\OCTGN\Data\GameDatabase\f44befce-4d6d-4fb9-a286-9585f36aece9\scripts\actions.py", line 504, in onCardsMoved File "", line 297, in name SystemError: Object reference not set to an instance of an object.

onCardsMoved(EventArgument({"player":Player(1), "cards":[Card(65608)], "fromGroups":[table], "toGroups":[table], "indexs":[2], "xs":[-315], "ys":[28], "highlights":["None"], "markers":["{}"], "faceups":[True], "filters":["None"], "alternates":[""]}))

zz1000zz commented 4 years ago

Others have reported this same issue, though it's unclear if it is limited to card movement caused by the Play Characters command. I've been unable to replicate it, with things working as intended whenever I test.

Even so, I'll be closing this. I've wrapped the section of code that's the source of the error in a try/except block so if it fails, it will do so silently and without effect on the game. The worst that should happen because of this is the Undo command will be rendered non-functional for people who would otherwise have gotten these errors.

That's obviously not desirable but the Undo feature is in active development. If the change does make the Undo feature not work, we can start a new issue ticket and reference this one.