search

zz85 / space-radar

Disk And Memory Space Visualization App built with Electron & d3.js
https://github.com/zz85/space-radar-electron/releases
1.38k stars 80 forks source link

version numbers broken on macOS #42

Open core-code opened 6 years ago

core-code commented 6 years ago

version 5.1.0 actually claims to be version 1.7.8 when selected in the Finder

dasmurphy commented 5 years ago

And the icon is also broken.

core-code commented 5 years ago

regarding the version number:

"build": "electron-packager app SpaceRadar --platform=darwin --arch=x64 --version=1.7.8 --version-string.CompanyName=zz85 --version-string.ProductName=SpaceRadar --icon=Icon.icns",

the problem is this line. it should read version=5.1.0

Amorymeltzer commented 9 months ago

Not my area of expertise, but seems like 561b5d1 didn't fix the issue, as this is still ongoing.