search

zz85 / sparks.js

a lightweight 3d particle engine in javascript, compatible with THREE.js and TWEEN.js
435 stars 47 forks source link

A defect may need to be fixed #12

Closed chilicomputer closed 12 years ago

chilicomputer commented 12 years ago

In Sparks.js line 113, its written that " this_.activities[i].update( this, time )". I think it should be "this.activities[i].update( this, time )" with "" after "this". Maybe this defect does not let the engine down, but I'm confused about what's the effect of "this._activities"？ Since I can't find any methods to add activities to emitter._activities in the Sparks.js .

All my best & Thax for this brilliant engine!

zz85 commented 12 years ago

@chilicomputer thanks for highlighting this, although there are currently no activities are not being created or used.

Just like how Actions affects particles, Activities affects the Emitter.

Potential activities could be MoveEmitterAlongPathActivity or MoveEmitterToCursorActivity. Any other suggestions are welcome! :)

zz85 commented 12 years ago

the typo has been correctly in the current repository. thanks! :)