examples/CanvasShaders.js barely used ?

zz85 / sparks.js

a lightweight 3d particle engine in javascript, compatible with THREE.js and TWEEN.js

435 stars 47 forks source link

examples/CanvasShaders.js barely used ? #3

Closed jeromeetienne closed 12 years ago

jeromeetienne commented 12 years ago

canvas examples uses various shapes for particles material.
Most examples got their own copy of this drawing code.
CanvasShaders.js would avoid this duplication but it is barely used

Why that ? historical reason ?

jeromeetienne commented 12 years ago

pull request welcomed if i remove the duplicated code for canvas drawing material ?

zz85 commented 12 years ago

you are right. CanvasShaders.js was meant to avoid duplicated code, but i was hastily doing "copy and paste". i'll be glad to do pull request again.

jeromeetienne commented 12 years ago

pull request submitted

zz85 commented 12 years ago

thanks for the work jerome! :)