search

zzag / kwin-effects-yet-another-magic-lamp

Just Yet Another Magic Lamp effect
GNU General Public License v2.0
162 stars 26 forks source link

Upstream this! #50

Closed openmindead closed 2 years ago

openmindead commented 2 years ago

Hi Vlad,

Is there any way we could have it (and sliding notifications, too) merged into upstream? I don't know, maybe vote or something? These effect is just too cool and looks way more appealing than a regular Magic Lamp from 2010.

zzag commented 2 years ago

I don't want to upstream this effect because it's a lot of code and kwin has already too many effects. As for the sliding notifications effect, plasma probably needs to use the sliding popups effect. I wrote that effect just to have something in the meanwhile.

openmindead commented 2 years ago

Oh what a pity. I thought it could be a good candidate as a "newer and more feature-packed" version of stock Magic lamp effect, kind of evolution of the latter. Maybe kwin needs a concept of core effects and a separate "extra-effects" pack? Anyway, thanks for the clarification and excellent work!

angrylinuxuser commented 2 years ago

TBH this effect is much better than magic lamp. I always wonder why this effect isn't upstreamed and magic lamp is.