search

zzag / kwin-effects-yet-another-magic-lamp

Just Yet Another Magic Lamp effect
GNU General Public License v2.0
162 stars 26 forks source link

Blur fix #73

Open GleammerRay opened 2 months ago

GleammerRay commented 2 months ago

I have looked into KDE's original magic lamp effect over at https://github.com/KDE/kwin/blob/1d57c9a5aff148061057af7e608c42c86bac0885/src/plugins/magiclamp/magiclamp.cpp and have introduced a few changes from it into this repo to fix the Blur effect not disappearing (#70).

You don't need to include all the changes for it to work, just the two changes up to and including 8b14c355cffa3406dac0613b183ffa00ea27c9a9 (Now animating in prePaintWindow). Apparently prePaintScreen animation now occurs before the blur effect is removed in newer Plasma versions, so prePaintWindow needs to be used.

Thanks a lot for this project, it is a beautiful addition to my Mac-like desktop setup.

GleammerRay commented 2 months ago

Apologies for the force push, I have made these changes about a month ago and forgot that the effect failed build with the latest changes when I was trying to improve it further. I have removed these breaking changes via force push as the pull request was only a couple of minutes old. :pray: