search

zzag / plasma5-wallpapers-dynamic

Dynamic wallpaper plugin for KDE Plasma
328 stars 18 forks source link

Plugin crash when selecting image #102

Closed Talkys closed 2 years ago

Talkys commented 2 years ago

When the latest release was the 3, I've set a HEIF wallpaper. But then I updated the program, tried to change the HEIF image to the AVIF one but now when I try to open the manager to select the wallpaper, it tries to read the HEIF image and crashes.

Then my wallpaper turns black (and on 4.0 the desktop just stoped working, needing a reset to default and a reboot) The builder is working fine, but this issue just makes it impossible to use.

Talkys commented 2 years ago

I've managed to do a workaround. Install the latest 3.x from source, delete all the wallpapers from the selector and uninstall. Install the newer version and it will work.

zzag commented 2 years ago

Do you use 4.0 or 4.3? If 4.3, can you get the backtrace of plasmashell or share the wallpaper so I could reproduce the crash myself.

Talkys commented 2 years ago

This issue can happen in both versions. I do not have the heic wallpaper anymore, but I have the source images. 0 1 2 3 4 5 6 7

I created the heic wallpaper in 3.3.9 then I updated the package to 4.0.0. Then as the wallpaper was not working anymore I waited for some updates then tried with the 4.3 but faced the same problem

zzag commented 2 years ago

Not all images have the same resolution, I'll make sure that preview code handles that corner case well, but I recommend to ensure that all images have the same size.

zzag commented 2 years ago

The crash should be fixed.

Talkys commented 2 years ago

You work fast, dude. Nice job!