search

zzag / plasma5-wallpapers-dynamic

Dynamic wallpaper plugin for KDE Plasma
329 stars 18 forks source link

when dynamicwallpaperconverter convert Catalina.heic has noises #58

Closed Littleweisheit closed 4 years ago

Littleweisheit commented 4 years ago

I use the python tool to convert Catalina.heic which file from macOS,and I use heif-convert to extra jpg(6016x6016). the first image is wallpaper screenshot.the second is extra from origin heic file. 图片 图片

zzag commented 4 years ago

What is the resolution of your display? and does omitting "--crossfade" helps to get rid of the noise?

zzag commented 4 years ago

Ideally, we need to specify the sourceSize so QtQuick can downscale the image the best it can, but it's not really an option right now due to the current QQuickImageProvider API limitations. With Qt 6, it will be possible to specify sourceSize, though.

zzag commented 4 years ago

The first image looks crisp, while the second one looks more blurry, I wonder whether it is downscaled using mipmaps.

Littleweisheit commented 4 years ago

显示器的分辨率是多少？ 省略“ --crossfade”是否有助于消除噪音？

I havent add --crossfade option,display resolution is 1080p(16:9).I also tried use png format,but also have noise.the transformed wallpapaer is 16:9.I dont know how it cahnge the length-width ratio.

Littleweisheit commented 4 years ago

The first image looks crisp, while the second one looks more blurry, I wonder whether it is downscaled using mipmaps.

second image is 6016x6016,I just use heif-convert imagename.heic.and I think second image is normal.

zzag commented 4 years ago

Hmm, I'm not sure that I understand what you are doing. Did you run heif-convert on both the original heic file and the heic file that the script had produced?

zzag commented 4 years ago

I believe that the script doesn't introduce any noise. The problem is the way how the images are downscaled. If that's indeed the case, I don't know how to fix this bug before Qt 6 is released without sacrificing performance.

Littleweisheit commented 4 years ago

I believe that the script doesn't introduce any noise. The problem is the way how the images are downscaled. If that's indeed the case, I don't know how to fix this bug before Qt 6 is released without sacrificing performance.

Thank you,I think it's downscaled probelem,because I convert other heic(not form macOS) work fine.

zzag commented 4 years ago

Just to be sure, could you please test whether enabling mipmapping fixes the problem?

0001-Use-mipmap-filtering.patch.txt