search

zzag / plasma5-wallpapers-dynamic

Dynamic wallpaper plugin for KDE Plasma
329 stars 18 forks source link

Italian translation filename (it-IT.po) is incorrect #60

Closed eeickmeyer closed 4 years ago

eeickmeyer commented 4 years ago

Hi there,

I have finished packaging plasma5-wallpapers-dynamic for Ubuntu. I ran into one issue: the Itialian translation name (it-IT.po) is incorrect and should simply be it.po. It was rather easy to patch, so attached is the patch I created (though it might be easier for you to simply rename it). Without this fix, lintian gave me a pretty sizable headache. :)

I'll probably package this for Fedora fairly soon as well, but I thought I'd at least make you aware of this issue.

0001-Fix-translation-filename.patch.txt

zzag commented 4 years ago

Thank you for reporting this issue. Can you please create a merge request? :-)

eeickmeyer commented 4 years ago

Done.

zzag commented 4 years ago

I have finished packaging plasma5-wallpapers-dynamic for Ubuntu.

@eeickmeyer Also, I should have mentioned that "plasma5-wallpapers-dynamic" follows Arch Linux package naming conventions. If it is a really bad package name according to Ubuntu/Debian conventions, please change it. It seems like "plasma-wallpaper-dynamic" is a better choice.

eeickmeyer commented 4 years ago

@zzag Thanks for that, I did change it. As of yesterday, this package is in the Ubuntu archives and it will be installed by default in Ubuntu Studio 20.10.

zzag commented 4 years ago

@eeickmeyer Awesome, that's really great to hear. :-)

If you receive any bug report, could you please CC me? I'm vladzzag on Launchpad.

eeickmeyer commented 4 years ago

@zzag What I'd do if I were you is just subscribe yourself here: https://launchpad.net/ubuntu/+source/plasma-wallpaper-dynamic/+subscribe. I can't subscribe you for you, but it would definitely cut-out the middle-man.

zzag commented 4 years ago

Okay, I'll do that, thanks.

On Sat, Aug 22, 2020, 3:45 AM Erich Eickmeyer notifications@github.com wrote:

@zzag https://github.com/zzag What I'd do if I were you is just subscribe yourself here: https://launchpad.net/ubuntu/+source/plasma-wallpaper-dynamic/+subscribe. I can't subscribe you for you, but it would definitely cut-out the middle-man.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zzag/plasma5-wallpapers-dynamic/issues/60#issuecomment-678568965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEXNQQTCEDE5IPAPRR3NJB3SB4IMBANCNFSM4PUSRPWQ .