search

zzangdol348 / mp4v2

Automatically exported from code.google.com/p/mp4v2
0 stars 0 forks source link

[patch] add some atoms to"ilst" expected atoms list #82

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Removes some messages from the new log callback.

Original issue reported on code.google.com by damiog on 7 Feb 2011 at 8:24

Attachments:

GoogleCodeExporter commented 8 years ago 
Just so I understand--is the new interface logging the existence of these atoms 
because we didn't inform mp4v2 that they were expected?

Original comment by jnor...@logitech.com on 8 Feb 2011 at 12:57

GoogleCodeExporter commented 8 years ago 
Right.
Here's a sample.

Original comment by damiog on 8 Feb 2011 at 7:11

Attachments:

GoogleCodeExporter commented 8 years ago 
Looks good--I'll try and get this in sometime today.

Original comment by jnor...@logitech.com on 8 Feb 2011 at 5:08

GoogleCodeExporter commented 8 years ago 
I tried the patch and it removes a bunch of warnings but there's still one left 
about a 'jpeg' atom.  We handle that with MP4VideoAtom (atom_video.cpp) but I 
don't see a note in the wiki 
(http://code.google.com/p/mp4v2/wiki/iTunesMetadata) about it.  Anyone know 
enough to write an entry for it?  Either way it looks like I should add 

ExpectChildAtom("jpeg", Optional...);

I guess the last arg should be OnlyOne but would nice to get someone to confirm.

Thanks.

-DB

Original comment by dbyr...@gmail.com on 8 Feb 2011 at 8:30

GoogleCodeExporter commented 8 years ago 
Oh that's unrelated. It's from a jpeg track.
But I'll send soon (maybe) a different patch for it.

Original comment by damiog on 8 Feb 2011 at 8:32

GoogleCodeExporter commented 8 years ago 
Thanks for the patch, sorry for the delay.  It's in now.  Let me know if you 
get the other patch for the jpeg track and I'll work on that one next.  
hopefully my turnaround time won't be a month this time... :(

Original comment by kid...@gmail.com on 17 Mar 2011 at 11:11