zzangjinsun / NLSPN_ECCV20

Park et al., Non-Local Spatial Propagation Network for Depth Completion, ECCV, 2020
MIT License
321 stars 57 forks source link

shuffle=False in training data loader? #24

Closed ChenyangLiu closed 3 years ago

ChenyangLiu commented 3 years ago

Hi, nice work! I'm wondering that why didn't you set the training data loader to be shuffled?

https://github.com/zzangjinsun/NLSPN_ECCV20/blob/ba33fa5d9ea62ca970026a145ab18fab76d79d4a/src/main.py#L101

zzangjinsun commented 3 years ago

Hi @ChenyangLiu,

as far as I know, DistributedSampler does shuffle so DataLoader shuffle is set to False.

https://github.com/zzangjinsun/NLSPN_ECCV20/blob/ba33fa5d9ea62ca970026a145ab18fab76d79d4a/src/main.py#L93-L96

Please refer to here.

ChenyangLiu commented 3 years ago

Thanks for your reply!