Merge CLI and Backend repos into this repo

zzap / docs-dangit

Other

13 stars 1 forks source link

Merge CLI and Backend repos into this repo #26

Closed dbeja closed 1 year ago

dbeja commented 1 year ago

Closes #25.

This PR splits the different projects into their directory and all merged on this repo.

KevinBatdorf commented 1 year ago

Looks ok to me but I'm maybe not the best to review the backend changes. Some notes though that stand out:

Will the backend deploy properly? The frontend deploy looks right.
The .editorconfig, .env, README.md, and .gitignore files (or maybe all config files??) should probably be merged and at the root of the project. (Maybe just use tabs with a width of 4 for * in .editorconfig)
add .DS_Store to the .gitignore
add the .env to gitignore and change that password. If it's not used, just delete the file.

dbeja commented 1 year ago

Looks ok to me but I'm maybe not the best to review the backend changes. Some notes though that stand out:

Will the backend deploy properly? The frontend deploy looks right.

The .editorconfig, .env, README.md, and .gitignore files (or maybe all config files??) should probably be merged and at the root of the project. (Maybe just use tabs with a width of 4 for * in .editorconfig)

add .DS_Store to the .gitignore

add the .env to gitignore and change that password. If it's not used, just delete the file.

Thanks, good points/suggestions.

heiglandreas commented 1 year ago

We should definitely use tabs for A11y reasons.

The .DS_Store belongs for sure not into the projects .gitignore. That's something for the local .gitignore setting that people using a Mac for development should have set up 😉

The .env is only necessary for local dev with docker anyhow. Either we convert that to a .env.local or .env.dist and require people to rename that for local dev or just keep it as it is....