class Synology_Abstract (Abstract.php) contains never used private $_errorCodes

zzarbi / synology

PHP Implementation of Synology Download Station

MIT License

126 stars 58 forks source link

class Synology_Abstract (Abstract.php) contains never used private $_errorCodes #22

Closed ronaldhoek closed 1 year ago

ronaldhoek commented 7 years ago

I suspect this is some leftover after you created a seperate file for the errorcodes (Exception.php)

zzarbi commented 7 years ago

It's used on line 179 https://github.com/zzarbi/synology/blob/master/src/Synology/Abstract.php#L179

ronaldhoek commented 7 years ago

OK, sorry. Missed that one. By why are you doing this anyway? Because you also have the same codes (except 100) declared in then 'Synology_Exception' exception class...

This would make the use of the $_errorCodes obsolete...