zzarcon / gh-emoji

Github emoji parsing done right :point_up: :pray: :point_up_2: :clap: :ok_hand:
http://zzarcon.github.io/gh-emoji/
MIT License
160 stars 7 forks source link

Modify tests to use gh-emoji api properly #20

Closed rpunkfu closed 8 years ago

ryyppy commented 8 years ago

Actually, when I think about it... aren't those integration tests? We should consider unit-testing too!

zzarcon commented 8 years ago

@ryyppy you're right, now the tests are kind of integration... That's why I think we should provide some fixtures for the emojis.

What about using fetch-mock and providing a subset of the actual emojis?

rpunkfu commented 8 years ago

:+1: