search

zzarcon / nodegram

:metal: Simplest Instagram Api library in Javascript
145 stars 6 forks source link

fix 'get' call to resolve both data and pagination #2

Closed rehia closed 8 years ago

rehia commented 8 years ago

Pagination is not reachable when calling get. It is not possible to resolve 2 parameters in a promise callback. You have to use an object to encapsulate multiple variables.

rehia commented 8 years ago

Hi @zzarcon ! I don't know if you have seen this PR, and if you're OK to merge it, or if you have any comments. I'll be glad to take your feedback

Thanks !

zzarcon commented 8 years ago

Hi @rehia! sorry for the delay, actually I didn't saw the PR (not sure why since Im watching this repo in my notification settings...).

Anyways, thanks for the PR, you are totally right with the changes. Actually I'm looking for maintainers, contributors to the project, so if you are interested I can grant you as member and we can make this better ^^

Just think about it and let me know, no compromises at all! Thanks!!

rehia commented 8 years ago

Thanks for the merge @zzarcon ! Yeah, actually, I think I can help. I don't know how often I can contribute, but as long as we are integrating Instagram in our product (take a look at https://www.tweetping.net), I'll be interested in some changes. So yeah, let's try !

zzarcon commented 8 years ago

@rehia that's amazing! actually my main concern right now is the leaking of tests, the current coverage it's pretty bad and I'd like to improve it, check https://github.com/zzarcon/nodegram/blob/master/tests/index.js

Anyways, welcome to the team! feel free to create any PR or issue 💪

rehia commented 8 years ago

thanks ! Actually, tests are one of my main concerns. I'll do my best. If you have any particular things you want to solve primarily, fill some issues and I'll do my best. We will also have to talk about npm publish. By the way, if you could publish a new version of the package, I'll be happy :)

zzarcon commented 8 years ago

Done v0.2.2! https://github.com/zzarcon/nodegram/releases/tag/v0.2.2