search

zzet / rbenv

Ansible role for installing rbenv.
https://galaxy.ansible.com/zzet/rbenv/
188 stars 112 forks source link

Add option to clean up old rubies #98

Closed ringe closed 7 years ago

ringe commented 7 years ago

I've added the rbenv_clean_up option.

I have tested this on my user install, but not on system. I also don't know how you run the tests. Please test and see if I should fix anything.

I changed the ruby_installed variable to just list all installed rubies, rather than loop over what to install. The install ruby tasks are adjusted to fit with this. It works in user install.

zzet commented 7 years ago

I changed the ruby_installed variable to just list all installed rubies, rather than loop over what to install.

This is good change, but better to do this in separated PR. I'm preferring to follow rule one feature - one PR, because in this case nobody has troubles with reverts (anything may be).

ringe commented 7 years ago

I see, I'll close this pull request and create new ones after I clean up and make the build pass.

ringe commented 7 years ago

See https://github.com/zzet/ansible-rbenv-role/pull/99 and https://github.com/zzet/ansible-rbenv-role/pull/100