search

zzhabib / CS-Jukebox

Create your own music kits in Counter-Strike: Global Offensive!
GNU General Public License v3.0
23 stars 4 forks source link

Removed duration parameter from Round Begun #10

Closed Crackhog closed 1 year ago

Crackhog commented 1 year ago

I removed the duration parameter from the Round Start song to let the user decide the duration themselves. Ideally, this would be handled by a seperate slider in the GUI, but that isn't really a priority I would assume.

Also, in my testing, the Round Start song ended earlier than the 8 seconds specified (It ended after around 1 second). I did not find the cause of that issue, or if it is an issue entirely on my side.

TimosCodd commented 1 year ago

I also noticed the issue with it stopping after 1 second, tho does this even fix it? Also, I think yeah the cap could be removed itself, but then it won't be autostopping like with e.G timeout. Prob best to keep the ability for caping (and set as default)

Crackhog commented 1 year ago

Other songs that lack the duration parameter still autostop when another song plays, don't they? I personally would love to have my "Round Start" song function as a "While in Round" song instead, by passing a song that's longer than 8 seconds

Also, I don't really know if that even fixed the 1 second issue as I can't really test it. I couldn't figure out how to build the project, as there are no build steps in the readme.

TimosCodd commented 1 year ago

Yeah they still autostop because the game state changes. The game start is if I remember correctly just ingame status, which is not changing (except bomb plant & 10 sec timer)

I like the Idea of it being changeable, tho not as just removing the value as a fix. I can take a look and make this as a changeable setting the next few days.

Crackhog commented 1 year ago

That would be great. I would also like to be able to contribute more than just removing a single value, so I was wondering how the project is compiled exactly? I don't want to PR some code that has never been tested before.

TimosCodd commented 1 year ago

Basicly it's just compiled with visual studio. Should be automaticly compilable when you open up the project. Alright, like I said I will check on it in the next few days :)

TimosCodd commented 11 months ago

I will come back to this idea when I have time for it. Still need to figure out the cause of the sudden cut, but I can assure you its not caused by the parameter.