zzlee / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

MP4Optimize fails under Windows #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Invoke MP4Optimize under Windows

What is the expected output? What do you see instead?
The function fails because "FileSystem::rename" (Win32) fails.

What version of the product are you using? On what operating system?
Trunk, rev. 468

Please provide any additional information below.

There is a typo in "FileSystem::rename" (Win32). There is a "!" missing for the 
second "IsUTF16Valid" expression.

It should look like this:

bool
FileSystem::rename( string from, string to )
{
    win32::Utf8ToFilename from_file(from);
    win32::Utf8ToFilename to_file(to);

    if (!from_file.IsUTF16Valid() || !to_file.IsUTF16Valid())
    {
        return true;
    }
...
...
...

Original issue reported on code.google.com by Skaa...@gmail.com on 30 May 2011 at 7:42

GoogleCodeExporter commented 9 years ago
fixed in r469.

Original comment by dbyr...@gmail.com on 30 May 2011 at 7:49