search

zzlee / mp4v2

Automatically exported from code.google.com/p/mp4v2
Other
0 stars 0 forks source link

mp4tags: Setting a track number or track count tag also adds a disk number tag #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Clear tags: mp4tags -r tTdD mp4file.m4a
2. Set the track number: mp4tags -t 1 mp4file.m4a

What is the expected output? What do you see instead?

Expected output from mp4info
----------------------------
mp4info version 1.9.1
01-The Cult-Wild Flower.m4a:
Track   Type    Info
1       audio   MPEG-4 AAC LC, 217.356 secs, 149 kbps, 44100 Hz
 Name: Wild Flower
 Artist: The Cult
 Encoded with: FAAC 1.28
 Release Date: 1987
 Album: Electric
 Track: 1 of 0
 Genre: Hard Rock
 Comments: 

Actual output from mp4info
--------------------------
mp4info version 1.9.1
01-The Cult-Wild Flower.m4a:
Track   Type    Info
1       audio   MPEG-4 AAC LC, 217.356 secs, 149 kbps, 44100 Hz
 Name: Wild Flower
 Artist: The Cult
 Encoded with: FAAC 1.28
 Release Date: 1987
 Album: Electric
 Track: 1 of 0
 Disk: 0 of 0
 Genre: Hard Rock
 Comments: 

What version of the product are you using? On what operating system?
mp4v2 1.9.1

Please provide any additional information below.

The attached patch will only update the disk number and disk count tags if -d 
or -D is provied on the command line.

Original issue reported on code.google.com by edwardne...@gmail.com on 19 Jan 2011 at 7:21

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch--looks like a good fix to me.  I'll work on getting this 
into mp4v2 this week.

Original comment by kid...@gmail.com on 25 Jan 2011 at 6:39

GoogleCodeExporter commented 9 years ago 
looks like this was a bug (?) introduced in r317; the code used to be 
structured exactly how you had it, so maybe it was a copy/paste error or 
something.  Your version looks more correct to me.  Should be in r441.

Original comment by kid...@gmail.com on 29 Jan 2011 at 2:25