search

zzo / browsermob-node

Javascript bindings for browsermob-proxy
MIT License
81 stars 33 forks source link

Allow a port to be specified in cbHAR #19

Closed jim-coffey closed 9 years ago

jim-coffey commented 9 years ago

Allow configuration of the proxyPort via the configuration object when creating the proxy, and/or by passing the port as a parameter to doHAR / cbHAR functions.

This is a mix of Pull Request : "Use specific proxy port for proxy sessions #8" which allows specifying proxyPort in conf object of new Proxy(conf)

and

My pull request 19 allowing proxyPort to be passed to cbHAR and doHAR convenience functions.

These changes would be really useful in cases where the user specifies the selenium httpProxy host:port in advance such as in a Nightwatch or theIntern configuration file, and then needs to make sure that tests running against it create the mobbrowser-proxy against the same port, rather than an incremenetally chosen one.

Otherwise, tests either have to : a.) predict the port - not always possible when tests run in parallel in different orders b.) write their own fine-tuned proxy start - run - stop behaviour

zzo commented 9 years ago

browsermob 1.0.9 published on npm thanks!