amplification icon - Githubissues

zzorba / marvelsdb-json-data

repository for marvelsdb json data

52 stars 81 forks source link

amplification icon #528

Open mmougy opened 2 months ago

mmougy commented 2 months ago

there are 2 different descriptors for the same concept: amplification icon ()

scheme_amplify
scheme_boost

both seems not supported:

What is the strategy to display the amplify icon?

jordanweiler commented 2 months ago

I created https://github.com/zzorba/marvelsdb/issues/250 for this issue. The backend doesn't support these fields yet but I've been actively coding the JSON against scheme_amplify for a while now so most of the newer cards that display this icon should be ready to work once the backend is updated. scheme_boost seems like an overloaded term with the other boost fields we already have and doesn't seem like a good name. The official icon is called amplify from the official rules.

mmougy commented 2 months ago

ok, i'll use "scheme_amplify" to describe an amplify icon

scheme_boost seems to have been used for the same purpose. i suggest to replace all "scheme_boost" by "scheme_amplify" to stay consistent

jordanweiler commented 2 months ago

Yes, any previous scheme_boost properties should be replaced by scheme_amplify once the feature is implemented on the backend.

FYI, scheme_amplify should be used for the card property but if it's within text we should use [amplify] just like we use [acceleration], [crisis], or [hazard] to display the icon within text.