search

zzossig / hugo-theme-zzo

Make a blog with hugo zzo theme!
https://themes.gohugo.io//theme/hugo-theme-zzo/en/
MIT License
739 stars 256 forks source link

IE11 support #93

Closed VictorZakharov closed 4 years ago

VictorZakharov commented 4 years ago

Is IE11 supported? Seeing lots of weird issues on it - had to fix completely broken stuff via custom css. Still way below Chrome func, no theme switching, no sidebar etc.

zzossig commented 4 years ago

I’ll check about it. I didn't tested the theme on IE

VictorZakharov commented 4 years ago

2-7% of users, depending on which stats you find. For example - https://www.stetic.com/market-share/browser/ Thanks for checking. Doesn't have to be perfect, just "not ugly".

nisrulz commented 4 years ago

Worth mentioning, Microsoft released the new Edge browser which runs chromium under the hood i.e it is going to be at par with Chrome browser.

https://www.microsoft.com/en-us/edge

This issue is still valid, however the market share for IE 11 will only reduce from now on because Microsoft itself is moving away from it.

zzossig commented 4 years ago

@VictorZakharov I have tried to support IE11. Overall UI is fine now in IE11, but there are some limitations.

  1. You can not use the gallery in IE11, because I use a library for the gallery and it is not working in IE11. Also, I need async, await syntax for the gallery.

  2. I use the grid CSS syntax to the layout of the project. It seems that IE11 has a different syntax. So, the sidebar component not positioned to the side, but the bottom.

  3. Some component has a different position. (margin, padding, top, left, ...)

VictorZakharov commented 4 years ago

@zzossig As long as nothing looks obviously broken, that should be fine.

zzossig commented 4 years ago

Did you check the theme on IE11? Can we close this issue now?

VictorZakharov commented 4 years ago

@zzossig I checked on https://themes.gohugo.io//theme/hugo-theme-zzo/en/ Doesn't look great. image And then this big cat picture at the bottom (almost full screen). Table of contents is completely messed up: https://themes.gohugo.io//theme/hugo-theme-zzo/en/posts/markdown-syntax/ Theme switcher doesn't work, it just navigates to page top. Search is broken, doesn't do anything. Negative margins here (looks broken): image

zzossig commented 4 years ago

No, the theme site not updated. The site update every 3 days. Check my blog https://zzossig.io

VictorZakharov commented 4 years ago

On your blog most pages give me 404 (English version):

404: NOT_FOUND Code: `RESOURCE_NOT_FOUND` ID: `cle1:zldhs-1579788068534-907ae6272dde`

It's difficult for me to navigate Korean, but overall it looks okay. BTW, regarding grid support, people are using auto-prefixer: https://medium.com/@elad/supporting-css-grid-in-internet-explorer-b38669e75d66

zzossig commented 4 years ago

My blog not supporting English. I just made the menus with no pages. I think we can close this issue now. I'll check the link later! Thank you for the information!

zzossig commented 4 years ago

I have quickly tested the Autoprefixer. It is a good stuff. But it does not generate the right code. 주석 2020-01-23 233625

주석 2020-01-23 233643

주석 2020-01-23 233700

VictorZakharov commented 4 years ago

According to this guy, it will not magically make your existing markup work in IE11, you might need to adjust syntax: https://css-tricks.com/css-grid-in-ie-css-grid-and-the-new-autoprefixer/ Quote:

Autoprefixer still can’t save you from everything
zzossig commented 4 years ago

I'll read the post for sure. I'll dig into it more when I have more time. Anyway, thanks for the information!