zzrough / gs-extensions-drop-down-terminal

Drop Down Terminal extension for the Gnome Shell
https://extensions.gnome.org/extension/442/drop-down-terminal/
GNU General Public License v3.0
416 stars 91 forks source link

Include dependencies for openSUSE #94

Open l300lvl opened 9 years ago

l300lvl commented 9 years ago

This is fairly straight-forward and I think we discussed this once but it may have been looked over, but to save everyone some headache(myself included as I had to figure this out again almost 2 years later)...

If you could include the dependency requirement for openSUSE in the popup it would be awesome.

I believe this only applies after 13.1 as the package doesn't seem to exist in 13.1, but I could be wrong. For 13.2/13.3 the requirement is

typelib-1_0-Vte-2.91

which can be installed by running

sudo zypper in typelib-1_0-Vte-2.91

and perhaps include a statement to search for typelib-vte since the version may change on openSUSE, the best solution I think would be something like this

sudo zypper se vte | grep typelib

I understand if theres a reason this isn't included, but some of us would find it greatly helpful.

Cheers and thanks for keeping up the great work, still rocking this 2 years later.

(edit: grep on in does not work. sorry for that)

zzrough commented 9 years ago

Thanks for the very detailed post, I really appreciate that.

I'll add a line about openSUSE. I suspect people using the terminal to know about command line of their distribution. They can also use their favorite package manager, so I do not think I'll put the whole command-line for all distros.

Since the version increase in the package name also changes for Debian/Ubuntu, I'd be tempted to change the line to:

on Debian/Ubuntu: the gir-1.2-vte-2.* package (not installed by default)

As installing package with glob patterns like asterisk works with apt-get. Do you know if it is possible to also do:

zypper in typelib-1_0-Vte-2.* ?

That would prove has a bit more robust against version change. I could use vte-* and not mentioning Vte-2.*, but if the library goes to 3.x there will certainly be changes and I'll need to work on it. It's better not to start than crashing :)

So my question is only: does installing support glob package matching?

l300lvl commented 9 years ago

I thought I had tried that already but yes actually glob matching does work all the way down to the last bit. So your solution would be the best. Thanks for replying quickly and I totally understand why this makes more sense so I tested another glob method and it works as well. A much better solution I'd say

sudo zypper in typelibVte Loading repository data... Reading installed packages... 'typelib-1_0-Vte-2_90' providing 'typelibVte' is already installed. No update candidate for 'typelib-1_0-Vte-2_90-0.34.9-1.1.x86_64'. The highest available version is already installed. Resolving package dependencies... Nothing to do.

I had no idea this worked and it's so much quicker it actualy makes life easier on me just knowing this.

So a huge thank you for explaining something new to me. globbing ftw!

Of course I only speak for openSUSE compat but the answer is yes, it works amazingly well.

l300lvl commented 9 years ago

sudo zypper in typelib*vte*

capitalization also doesnt matter but you can glob inbetwen as well