search

zztin / ctimer

This is a python implementation of a famous time management technique. CTimer helps you keep track of your productivity during the day, and help you set realistic goals for your day.
Apache License 2.0
0 stars 1 forks source link

update date every time when clock restart #20

Closed zztin closed 4 years ago

zztin commented 4 years ago

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)

Types of changes

Please put an x in the box that applies

Description

Describe what the change is Previously the date on top of the clock is set once launched. Now the date is re-checked every time a clock finishes.

Steps to Test This Pull Request

Steps to reproduce the behavior: I haven't think of a nice way of testing the desired behavior.

zztin commented 4 years ago

sounds good.

On Tue, Jul 21, 2020 at 6:04 AM Taihsiang Ho notifications@github.com wrote:

@tai271828 approved this pull request.

The implementation is elegant. I like it very much.

not for this pull request: I smell some duplicated lines. Maybe we could a function like refresh_widgets in the future pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zztin/ctimer/pull/20#pullrequestreview-452110925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2QX2K3VRSHGY4LP4VETQTR4UHVLANCNFSM4PB6RLPA .