fix(packaging): make visual be a package - Githubissues

zztin / ctimer

This is a python implementation of a famous time management technique. CTimer helps you keep track of your productivity during the day, and help you set realistic goals for your day.

Apache License 2.0

0 stars 1 forks source link

fix(packaging): make visual be a package #34

Closed tai271828 closed 4 years ago

tai271828 commented 4 years ago

Types of changes

Please put an x in the box that applies

[x] Bugfix
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description

by specifying visual as a package we could include the package correctly to launch ctimer

Steps to Test This Pull Request

Steps to reproduce the behavior:

make dist
create a venv and then installed the wheel file generated in the previous step
launch ctimer

Expected behavior

ctimer is launched without error.

Additional context The 1.0.0 release in PyPI is not packaged correctly and will show ModuleNotFoundError: No module named 'ctimer.visual' .