zzxxpp1011239740 / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

WebPIUpdate failure #105

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a new incremental decoder with WebPINewDecoder(NULL);
2. Use WebPIUpdate with a value that increases slowly (e.g., increments of 1).

What is the expected output? What do you see instead?
Returns from WebPIUpdate should go from VP8_STATUS_SUSPENDED to VP8_STATUS_OK.
With this there's a possibility of receiving VP8_STATUS_BITSTREAM_ERROR.

Bug exists in v0.1.2 & v0.1.3.

Original issue reported on code.google.com by jz...@google.com on 1 Feb 2012 at 12:44

GoogleCodeExporter commented 9 years ago
https://gerrit.chromium.org/gerrit/#change,15124

Original comment by jz...@google.com on 1 Feb 2012 at 12:50

GoogleCodeExporter commented 9 years ago
From the commit message:

If the first call to WebPIUpdate contained all of partition 0, but not
enough to decode a macroblock the test for max macro block size could
fail (4096 bytes) due to a memory buffer offset not being updated.
This change offsets the buffer in the same manner as Append().

In practice this might occur over a slow network connection, though the window 
of failure is small, 10s of bytes.

Original comment by jz...@google.com on 1 Feb 2012 at 12:53

GoogleCodeExporter commented 9 years ago
v0.1.3-150-g89cd1bb

Original comment by jz...@google.com on 1 Feb 2012 at 7:38

GoogleCodeExporter commented 9 years ago
Merged as v0.1.3-152-g85b6ff6

Original comment by jz...@google.com on 1 Feb 2012 at 7:40