search

zzxxpp1011239740 / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

"master" branch does not build on Visual C++ 2010 SP1 #80

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. type "nmake /f Makefile.vc CFG=release-static RTLIBCFG=static OBJDIR=output" 
at a Visual Stuido 2010 command prompt

What is the expected output? What do you see instead?

expected: compiled encoder/decoder binaries
instead: linker/compiler errors.

first error:

libwebp_a.lib(dsp.obj) : error LNK2019: unresolved external symbol 
_VP8DspInitSSE2 referenced in function _VP8DspInit
output\release-static\x86\bin\dwebp.exe : fatal error LNK1120: 1 unresolved 
externals

after the attached patch, I see this error:

src\dec\dsp_sse2.c(37) : error C2719: 'q1': formal parameter with 
__declspec(align('16')) won't be aligned

What version of the product are you using? On what operating system?
master revision
Windows 7 64-bit
Visual Studio 2010 Professional SP1

Please provide any additional information below.

Seems like VC++ does not like aligned struct definitions in <emmintrin.h>. 
Probably data needs to be passed as types like uint8_t* to DoFilter2SSE2() and 
loads should be done in the function. I havent done any work on SIMD 
intrinsics, so I cant solve the problem on my own.

Original issue reported on code.google.com by devilgr...@gmail.com on 15 Jun 2011 at 8:17

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the report and the patch. Assigning to Somnath.

Original comment by rab...@google.com on 15 Jun 2011 at 5:21

GoogleCodeExporter commented 9 years ago 
https://review.webmproject.org/#change,2500

Provides a temporary workaround until the core issue can be addressed.

Original comment by jz...@google.com on 15 Jun 2011 at 8:43

GoogleCodeExporter commented 9 years ago 
https://review.webmproject.org/#change,2525
Fixes the compile.

https://review.webmproject.org/#change,2526
Adds dsp_sse2.c to the Visual Studio build.

Original comment by jz...@google.com on 18 Jun 2011 at 1:26

GoogleCodeExporter commented 9 years ago 
And one more just to avoid any possible problems with aligned stores.
https://review.webmproject.org/#change,2527

Original comment by jz...@google.com on 18 Jun 2011 at 4:44

GoogleCodeExporter commented 9 years ago

Original comment by jz...@google.com on 20 Jun 2011 at 11:32