zzxxpp1011239740 / webp

Automatically exported from code.google.com/p/webp
0 stars 0 forks source link

"master" branch does not build on Visual C++ 2010 SP1 when WEBP_EXPERIMENTAL_FEATURES defined #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add /DWEBP_EXPERIMENTAL_FEATURES to CFLAGS in Makefile.vc
2. Type "nmake /f Makefile.vc CFG=release-static RTLIBCFG=static OBJDIR=output" 
at a Visual Studio 2010 command prompt

What is the expected output? What do you see instead?

expected: compiled encoder/decoder binaries
instead: compiler errors.

VC++ gives me compiler error C2057. I lost the exact error messages but 
changing the lines in the attached patch fixes them.

What version of the product are you using? On what operating system?

master revision
Windows 7 64-bit
Visual Studio 2010 Professional SP1

Please provide any additional information below.

VC++ 2010 (and probably previous versions) is not full C99 compliant. It does 
not count a local "const int" as a real constant and does not allow variable 
length arrays.

Original issue reported on code.google.com by iskes...@gmail.com on 16 Jun 2011 at 1:35

GoogleCodeExporter commented 9 years ago
Here is the patch, that I forgot to attach.

Original comment by iskes...@gmail.com on 16 Jun 2011 at 1:36

Attachments:

GoogleCodeExporter commented 9 years ago
thanks! applied. (https://review.webmproject.org/2517)

Original comment by pascal.m...@gmail.com on 16 Jun 2011 at 8:38