zzybluebell / pe

0 stars 0 forks source link

Same phone number occupy #5

Open zzybluebell opened 2 years ago

zzybluebell commented 2 years ago

Multiple user can have same 2nd and 3d with same HP: 9875432

Screenshot 2021-11-12 at 4.31.09 PM.png

Screenshot 2021-11-12 at 4.32.28 PM.png

nus-se-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Same Telegram handle and Github username not allowed for add command but same phone number allowed.

The restriction placed for same telegram handle and same github username makes sense, but I feel that this restriction should be placed on phone numbers as well (even though it's an optional), since there should not be duplicate people with the same phone number.

Screenshot 2021-11-12 at 4.40.25 PM.png

Screenshot 2021-11-12 at 4.40.35 PM.png


[original: nus-cs2103-AY2122S1/pe-interim#35] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Users are only considered unique by GitHub and Telegram. Two contacts can share the same phone number although it is unlikely. For example, if they are from the same family and give their home phone number.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Don't think this is a proper explanation for the same Phone Number shared with 2 different contacts


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]