MapperExtension's append_result and populate_instance's docs/API are incorrect

[zzzeek]

Originally reported by: Anonymous

---

The docs (or is it the API) for both of these extension functions are incorrect. The docs say:

If this method returns True, it is assumed that the mapper should do the appending, else
if this method returns False, it is assumed that the append was handled by this method.

The code actually expects these functions to return sqlalchemy.orm.mapper.EXT_PASS to notify the mapper should do the appending, and anything else assumes the append was handled by the extension method

There may be others that are also doing the wrong thing (probably create_instance)

---

• Bitbucket: https://bitbucket.org/zzzeek/sqlalchemy/issue/220

[zzzeek]

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

---

Removing milestone: 0.3.0 (automated comment)

[zzzeek]

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

---

the recent refactoring of mapper.instances() has fixed this (although the API has changed...)

[zzzeek]

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

---

always me me me.....

[zzzeek]

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

---

yah the ME docs have fell by the wayside a bit....would you have time to go through the method docs and submit a patch for me ? else ill try to get to this....