search

zzzeek / sqla_issue_test

1 stars 0 forks source link

Various little fixes to Firebird reflection #268

Closed zzzeek closed 6 years ago

zzzeek commented 18 years ago

Originally reported by: Anonymous

FB reflection has a little bug: it uses sqltypes.Double() instead of .Float() to represent double precision fields; the former does not even exist.

Also, it doesn't load the primary key fields.

The attached patch cures this problems. If this sounds good, I will try to complete the fix with another patch for the foreign keys.

zzzeek commented 10 years ago

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

Removing milestone: 0.4.0 (automated comment)

zzzeek commented 17 years ago

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

Milestone next micropoint release deleted

zzzeek commented 18 years ago

Original comment by Anonymous:

Can the reflection be two queries instead of three by removing the primary key query and selecting in the foreign keys query the primary keys too.

WHERE RC.RDB$CONSTRAINT_TYPE IN ('PRIMARY KEY', 'FOREIGN KEY')
zzzeek commented 18 years ago

Original comment by Michael Bayer (Bitbucket: zzzeek, GitHub: zzzeek):

this is committed in changeset:1789. i have no resources to test firebird so hopefully this one works already.

zzzeek commented 18 years ago

Original comment by Anonymous:

Augmented version, that implements also FKs

zzzeek commented 18 years ago

Original comment by Lele Gaifax (Bitbucket: lele, GitHub: lele):

Patch that fixes a glitch and initialize primary_key