ms-sql fails during reflection

[sqlalchemy-bot]

Issue created by Anonymous

---

sp_columns is called during reflection of tables... right now it's called with the schema prepended, like 'dbo.mytable'. this is incorrect syntax (on 2005 at least). i've attached a patch which lets it work.

HTH, --craig

#!diff
Index: lib/sqlalchemy/databases/mssql.py
===================================================================
--- lib/sqlalchemy/databases/mssql.py   (revision 3933)
+++ lib/sqlalchemy/databases/mssql.py   (working copy)
@@ -605,7 +605,10 @@
             raise exceptions.NoSuchTableError(table.name)

         # We also run an sp_columns to check for identity columns:
-        cursor = connection.execute("sp_columns %s" % self.identifier_preparer.format_table(table))
+        cursor = connection.execute(
+            "sp_columns @table_name = '%s', @table_owner = '%s'"
+            % (table.name, current_schema))
+        
         ic = None
         while True:
             row = cursor.fetchone()

---

Attachments: p1.patch

[sqlalchemy-bot]

Michael Bayer (zzzeek) wrote:

---

Removing milestone: 0.4.xx (automated comment)

[sqlalchemy-bot]

Michael Bayer (zzzeek) wrote:

---

[sqlalchemy-bot]

Anonymous wrote:

---

whoops... wiki didn't like the patch. attached.

[sqlalchemy-bot]

Anonymous wrote:

---

(original author: ram) 116e19f7f0c9a7c50ea52825a70ac00a83e95fa8, thanks for the patch