search

zzzeek / test_sqlalchemy

0 stars 0 forks source link

fully qualify schema names in all cases #999

Closed sqlalchemy-bot closed 16 years ago

sqlalchemy-bot commented 16 years ago

Issue created by Michael Bayer (zzzeek)

two schemas with the same tablename will produce a conflict currently. Patch is attached which turns on schema qualification across the board. Remove the redundant logic from the mssql.py module and others who may have hardcoded this; tests need to be added for PG,Oracle etc. to ensure that all SELECT/INSERT/UPDATE/DELETE works (as in, is accepted by the DB) with schema-qualified tables.

Attachments: fully_qualified_columns.patch

sqlalchemy-bot commented 10 years ago

Michael Bayer (zzzeek) wrote:

Removing milestone: 0.4.xx (automated comment)

sqlalchemy-bot commented 16 years ago

Michael Bayer (zzzeek) wrote:

added some tests for PG and applied the patch in 7512b5e5482ea8a01095f98f82f1380f19a07110. Any DB that supports a schema-qualified tablename has to support it within column expressions as well (will leave it to the userbase to reveal some weird MaxDB/Firebird glitch).

also commented on the above MS-SQL tickets which aren't directly impacted by this.

sqlalchemy-bot commented 16 years ago

Anonymous wrote:

(original author: ram) Have a look at tickets 594 and 973 for some potentially complicating factors.

sqlalchemy-bot commented 10 years ago

Changes by Michael Bayer (zzzeek): removed "0.4.xx" milestone

sqlalchemy-bot commented 16 years ago

Changes by Michael Bayer (zzzeek): set state to "resolved"