search

zzzprojects / Dapper-Plus

Dapper Plus - High-Efficient Bulk Actions (Insert, Update, Delete, and Merge) for .NET
https://dapper-plus.net/
385 stars 85 forks source link

License issue #11

Closed svher closed 7 years ago

svher commented 7 years ago

Calling different DapperPlusManager.ValidateLicense overloads have different behavior. I think this is a bug, please fix.

JonathanMagnan commented 7 years ago

Hello @svhero658 ,

What do you mean by different behavior?

We have two overloads:

public static bool ValidateLicense(DapperProviderType provider = DapperProviderType.SqlServer)
public static bool ValidateLicense(out string errorMessage, DapperProviderType provider = DapperProviderType.SqlServer)

Best Regards,

Jonathan

svher commented 7 years ago

The overload without out parameter cannot verify the license correctly

JonathanMagnan commented 7 years ago

You are right. We made a mistake by copying some code from one of our other libraries.

The v1.2.8 has been released: https://www.nuget.org/packages/Z.Dapper.Plus/

Let me know if everything now works as expected.

Best Regards,

Jonathan

svher commented 7 years ago

OK I'll check later. Thanks for your timely response.

JonathanMagnan commented 7 years ago

Hello @svhero658 ,

I will close this issue since it should be solved.

Best Regards,

Jonathan