zzzprojects / Dapper-Plus

Dapper Plus - High-Efficient Bulk Actions (Insert, Update, Delete, and Merge) for .NET
https://dapper-plus.net/
378 stars 83 forks source link

ASP.NET Core App Services (linux based) doesn't allow "dots" in the app setting name #70

Open jakehockey10 opened 3 years ago

jakehockey10 commented 3 years ago

First, thank you for all the hard work that went into this, this is a really useful tool!

With dots in the name of the app setting/configuration, setting the App Setting in appsettings.json per your documentation works just fine. But if you don't want to check that into your repository, and you use something like Azure DevOps to set your App Service's App Settings during a release pipeline run, this setting can break with dots in the name when your App Service is linux based.

I just wanted to mention this in case your team thought this was worth mentioning in some area of the documentation for future users. This deviated from your current documentation, but our solution ended up being removing the dots from the configuration name, and it all still worked. Even without validating the license in code. Having appsettings with the configuration name "ZDapperPlus" worked just fine.

JonathanMagnan commented 3 years ago

Hello @jakehockey10 ,

Be very careful, you might be in a trial mode at this moment since our library didn't discover your license (trial might expire in September or October depending on your version).

However, we will look at it and add support to underscore such as Z_Dapper_Plus and maybe Z-Dapper-Plus next week.

Best Regards,

Jon

jakehockey10 commented 3 years ago

@JonathanMagnan Thanks for the heads up, you might be right. I'll look for an update next week sometime and update my nuget version as well as my app setting name to a supported format.

JonathanMagnan commented 3 years ago

Hello @jakehockey10 ,

The v3.0.20 has been released.

We now support 3 versions:

We will update our documentation in around 1 months to reflect that since we prefer to wait a little bit and announce starting from version released in October (even if a little bit before), new names with underscore for example are now supported.

Let me know if everything work on your side.

Best Regards,

Jon