zzzprojects / EntityFramework-Classic

Entity Framework Classic is a supported version of the latest EF6 codebase. It supports .NET Framework and .NET Core and overcomes some EF limitations by adding tons of must-haves built-in features.
https://entityframework-classic.net
Other
103 stars 27 forks source link

EntityFrameworkManager.UseDatabaseFirst() assumes windows paths #10

Closed neoGeneva closed 5 years ago

neoGeneva commented 5 years ago

When using a linux path when calling EntityFrameworkManager.UseDatabaseFirst() a DirectoryNotFoundException exception is thrown:

DirectoryNotFoundException: Could not find a part of the path '/app\bin/Debug/netcoreapp2.1/DataModel.edmx'.
  Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, string path, bool isDirectory, Func<ErrorInfo, ErrorInfo> errorRewriter)
  Microsoft.Win32.SafeHandles.SafeFileHandle.Open(string path, OpenFlags flags, int mode)
  System.IO.FileStream..ctor(string path, FileMode mode, FileAccess access, FileShare share, int bufferSize, FileOptions options)
  System.IO.StreamReader..ctor(string path, Encoding encoding, bool detectEncodingFromByteOrderMarks, int bufferSize)
  Z.EntityFramework.Classic.UseDatabaseFirstManager.Execute(string modelName)
JonathanMagnan commented 5 years ago

Hello @neoGeneva ,

Thank you for reporting, we will look at it today.

We will change all backslashes for foward slashes which seem to be the standard everywhere.

Best Regards,

Jonathan

neoGeneva commented 5 years ago

Hey, thanks for that.

I managed to get things working locally by writing my own implementation of UseDatabaseFirstManager.Execute(), note that I'm calling OutputXml() twice, once with the full path and a second time with just the name because after fixing the slashes (which solved my initial problem) I started getting The given key 'DataModel.csdl' was not present in the dictionary. when callingDbContextExtensions.UpdateFromQuery()

Here's my working hack:

namespace Z.EntityFramework.Classic.Hacks
{
    // THIS IS A HACK TO DEAL WITH Z.EntityFramework.Classic ASSUMING WINDOWS PATHS
    internal class UseDatabaseFirstManager
    {
        internal static void Execute(string modelName)
        {
            var path = Path.Combine(Directory.GetCurrentDirectory(), modelName);
            var fileInfo = new FileInfo(path);

            using (StreamReader reader = new StreamReader(fileInfo.FullName))
            {
                // GET model element
                XmlElement conceptualSchemaElement;
                XmlElement mappingElement;
                XmlElement storageSchemaElement;
                string processingValue;
                EntityDesignerUtils.ExtractConceptualMappingAndStorageNodes(reader, out conceptualSchemaElement, out mappingElement, out storageSchemaElement, out processingValue);

                // SAVE model element
                OutputXml(Path.ChangeExtension(fileInfo.FullName, "csdl"), conceptualSchemaElement);
                OutputXml(Path.ChangeExtension(fileInfo.Name, "csdl"), conceptualSchemaElement);
                OutputXml(Path.ChangeExtension(fileInfo.FullName, "msl"), mappingElement);
                OutputXml(Path.ChangeExtension(fileInfo.Name, "msl"), mappingElement);
                OutputXml(Path.ChangeExtension(fileInfo.FullName, "ssdl"), storageSchemaElement);
                OutputXml(Path.ChangeExtension(fileInfo.Name, "ssdl"), storageSchemaElement);
            }
        }

        private static void OutputXml(string outputPath, XmlElement xmlElement)
        {
            var type = Type.GetType("Z.EntityFramework.Classic.UseDatabaseFirstManager, Z.EntityFramework.Classic, Version=7.0.0.0, Culture=neutral, PublicKeyToken=afc61983f100d280");
            var method = type.GetMethod("OutputXml", BindingFlags.Static | BindingFlags.NonPublic);

            method.Invoke(null, new object[] { outputPath, xmlElement });
        }
    }

    internal static class EntityDesignerUtils
    {
        internal static void ExtractConceptualMappingAndStorageNodes(StreamReader edmxInputStream, out XmlElement conceptualSchemaNode, out XmlElement mappingNode, out XmlElement storageSchemaNode, out string metadataArtifactProcessingValue)
        {
            var type = Type.GetType("Z.EntityFramework.Classic.EntityDesignerUtils, Z.EntityFramework.Classic, Version=7.0.0.0, Culture=neutral, PublicKeyToken=afc61983f100d280");
            var method = type.GetMethod("ExtractConceptualMappingAndStorageNodes", BindingFlags.Static | BindingFlags.NonPublic);

            var parameters = new object[] { edmxInputStream, null, null, null, null };

            method.Invoke(null, parameters);

            conceptualSchemaNode = (XmlElement)parameters[1];
            mappingNode = (XmlElement)parameters[2];
            storageSchemaNode = (XmlElement)parameters[3];
            metadataArtifactProcessingValue = (string)parameters[4];
        }
    }
}
JonathanMagnan commented 5 years ago

Nice hack ;)

Unfortunately, EFE has been built with windows path as well otherwise your fix would have worked great.

A new version v7.0.15 has been released.

We should now replace all \ by / to support all systems.

Let me know if that is working correctly on your side.

Best Regards,

Jonathan

neoGeneva commented 5 years ago

Thanks! I've got the latest version and it works great, so thanks again!