zzzprojects / EntityFramework-Classic

Entity Framework Classic is a supported version of the latest EF6 codebase. It supports .NET Framework and .NET Core and overcomes some EF limitations by adding tons of must-haves built-in features.
https://entityframework-classic.net
Other
103 stars 27 forks source link

Make DbMigrator constructors public #57

Closed schuettecarsten closed 3 years ago

schuettecarsten commented 4 years ago

Please make the following internal constructor of DbMigrator public - as it is in EF6:

    internal DbMigrator(DbMigrationsConfiguration configuration, DbContext usersContext)
JonathanMagnan commented 4 years ago

Sure, it will be done for the next release unless it causes some conflict

JonathanMagnan commented 3 years ago

Hello @schuettecarsten ,

The v7.1.30 has been released.

The DbMigrator constructor is now public.

Let me know if everything works as expected.

Best Regards,

Jon

schuettecarsten commented 3 years ago

Hi,

I just upgraded to v7.1.30 but still get the error:

var migrator = new DbMigrator(configuration, dbContext);
error CS1729: 'DbMigrator' does not contain a constructor that takes 2 arguments
JonathanMagnan commented 3 years ago

You are right!

Look like I forget one important step when merging the branch... ;)

The v7.1.31 has been released.

Let me know if everything works as expected.