search

zzzprojects / html-agility-pack

Html Agility Pack (HAP) is a free and open-source HTML parser written in C# to read/write DOM and supports plain XPATH or XSLT. It is a .NET code library that allows you to parse "out of the web" HTML files.
https://html-agility-pack.net
MIT License
2.65k stars 375 forks source link

Set PackageLicenseExpression on nuget #544

Closed thompson-tomo closed 6 months ago

thompson-tomo commented 7 months ago

Summary

I wish for the nuget packages to have the licence expression property set correctly

Details

The licence expression property should be set to the correct licence type (depending on the repo) as this will enable analysis of licences in use to occur in external tools & the license type will be shown in Nuget etc.

JonathanMagnan commented 7 months ago

Hello @thompson-tomo

I'm not sure what you are trying to say, the current license on NuGet currently points to this URL: https://github.com/zzzprojects/html-agility-pack/blob/master/LICENSE

Let me know more about your concerns.

Best Regards,

Jon

thompson-tomo commented 7 months ago

@JonathanMagnan i am using cyclonedx to generate SBOM's of all the libraries i am using and checking licence compliance which leverages the licence expression being set. Also by having it set it becomes easiliy visible in nuget.org

JonathanMagnan commented 7 months ago

Oh ok, I understand @thompson-tomo ,

It will be done the next time we release HAP

Best Regards,

Jon

JonathanMagnan commented 6 months ago

Hello @thompson-tomo ,

A new version is now available.

I don't really like it, as we now point to a generic page: https://licenses.nuget.org/MIT instead of the license that include the information, but oh well, since it looks like all majors packages I verified are doing it, I guess we will just stay like this.

Let me know if everything now works on your side.

Best Regards,

Jon

thompson-tomo commented 6 months ago

Looks good so will close issue