">" inside "a" element "href" attribute causes value truncation

[mikehenry1979-bah]

I am using this very cool package v1.11.66 to add attributes to "a" elements in PHP source code files. I am only running across one snag that does not cause an exception. If I parse an element such as: <a target=\"_blank\" href=\"$CFG->wwwroot/course/view.php?id=$course->id\">$shortname ->

Instead of getting $CFG->wwwroot/course/view.php?id=$course->id for the "href" attribute value, I only get $CFG-

Note that those are literal \ and not escape characters. I can work around this by changing the HTML to <a target=\"_blank\" href=\"$CFG->wwwroot/course/view.php?id=$course->id\">$shortname -> before parsing it, but it would be nice if this could be handled since it's contained inside the " pair. I'm guessing it's also a possibility that the \" containment vs " is causing the problem.

[mikehenry1979-bah]

Ah, markdown interfered with my post. Please see attachment. HAP sample.txt

[mikehenry1979-bah]

Also, the attached line does parse properly. HAP sample 2.txt

[JonathanMagnan]

Hello @mikehenry1979-bah ,

Thank you for reporting.

We will look at it very soon.

Best Regards,

Jon

[JonathanMagnan]

Hello @mikehenry1979-bah ,

Do you think you could create a Fiddle or a runnable project with the issue? It doesn’t need to be your project, just a new solution with the minimum code to reproduce the issue.

I just made a simple test and everything is working: https://dotnetfiddle.net/yUfgJW

var document = new HtmlDocument();
document.LoadHtml("<a target=\"_blank\" href=\"$CFG->wwwroot/course/view.php?id=$course->id\">$shortname</a>");

var href = document.DocumentNode.SelectSingleNode("//a").GetAttributeValue("href", "");

Console.WriteLine(href);

(I also tried when reading a file)

So I'm probably missing something from my simple test. Knowing how to get the same issue as you will surely help me.

Best Regards,

Jon

[JonathanMagnan]

Hello @mikehenry1979-bah,

Since our last conversation, we haven't heard from you.

As previously mentioned we would need a runnable project to assist you.

Let me know if you have questions.

Best regards,

Jon

[mikehenry1979-bah]

Apologies, I’ve been pulled from that work for the immediate time. If you were able to get it to work, this issue can be closed.

From: Jonathan Magnan @.> Sent: Thursday, October 3, 2024 8:41 AM To: zzzprojects/html-agility-pack @.> Cc: mikehenry1979-bah @.>; Mention @.> Subject: [External] Re: [zzzprojects/html-agility-pack] ">" inside "a" element "href" attribute causes value truncation (Issue #570)

Hello @mikehenry1979-bah, Since our last conversation, we haven't heard from you. As previously mentioned we would need a runnable project to assist you. Let me know if you have questions. Best regards, Jon — Reply to this email directly,

Hello @mikehenry1979-bahhttps://urldefense.com/v3/__https:/github.com/mikehenry1979-bah__;!!May37g!NUMdpQtsDU8v4umVHtsSelbwoOeDsaZbl1U_YCJdu3nGQlc5l0b6JPB4qw_AnTLFaRFwMQ-fiiqr_Tnu574PdGOK$,

Since our last conversation, we haven't heard from you.

As previously mentioned we would need a runnable project to assist you.

Let me know if you have questions.

Best regards,

Jon

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/zzzprojects/html-agility-pack/issues/570*issuecomment-2391319638__;Iw!!May37g!NUMdpQtsDU8v4umVHtsSelbwoOeDsaZbl1U_YCJdu3nGQlc5l0b6JPB4qw_AnTLFaRFwMQ-fiiqr_Tnu5zNAv7qo$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ATOWFGQ25PCFCVMORTXZRKLZZU3NTAVCNFSM6AAAAABO46CK2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGMYTSNRTHA__;!!May37g!NUMdpQtsDU8v4umVHtsSelbwoOeDsaZbl1U_YCJdu3nGQlc5l0b6JPB4qw_AnTLFaRFwMQ-fiiqr_Tnu5wICptdv$. You are receiving this because you were mentioned.Message ID: @.**@.>>

[JonathanMagnan]

Hello @mikehenry1979-bah

Perfect, we will close it.

We will re-open it when you will be able to provide an example.

Best Regards,

Jon