zzzprojects / sqlfiddle

http://sqlfiddle.com
MIT License
275 stars 52 forks source link

Use improved sql.js from https://github.com/lovasoa/sql.js #75

Closed crayxt closed 10 years ago

crayxt commented 10 years ago

Hi,

Original sql.js has some issues handling Cyrillic letters, see https://github.com/jakefeasel/sqlfiddle/issues/74 https://github.com/kripken/sql.js/issues/46

Please review and switch to (if appropriate) improved sql.js from https://github.com/lovasoa/sql.js

Regards

jakefeasel commented 10 years ago

I have tried out his fork. Unfortunately, pulling in his version breaks jQuery (it defines its own $ in the global scope). Until that is fixed, I won't be able to use it.

lovasoa commented 10 years ago

Can you please open a bug in sql.js?

crayxt commented 10 years ago

@lovasoa ok but you have to enable Issues in your sql.js repo

lovasoa commented 10 years ago

Done :)