zzzteph / sheye

Opensource assets and vulnerability scanning tool
https://shrewdeye.app
146 stars 36 forks source link

Update docker structure #3

Closed WesSec closed 1 year ago

WesSec commented 1 year ago

I made small changes to the docker structure, it now copies the local files in the dockerfile sequence instead of cloning the GitHub repo again. This will reflect local changes such as changes in de .env.docker file (which i use to change database location)

This shouldn't affect any documentation or other workflows

zzzteph commented 1 year ago

Thanks! The initial idea was to create a docker image that could be published to docker.hub. Not 100% how it should be done, but maybe, in this case, copying files from the git repository will require. But it's another kind of task =)

zzzteph commented 1 year ago

Dockerfile should be moved to the root folder in this case.

WesSec commented 1 year ago

Depending on how you want to structure the project it could be moved to root folder indeed (which is a better practice, but didn't want to make too many changes to the total structure for now).