Gaussian radius implementation is wrong

zzzxxxttt / pytorch_simple_CenterNet_45

A simple pytorch implementation of CenterNet (Objects as Points)

308 stars 63 forks source link

Gaussian radius implementation is wrong #5

Closed kikirizki closed 4 years ago

kikirizki commented 4 years ago

The official centernet repo is based on cornernet repo, the code for gaussian radius is wrong, please refer to this issue https://github.com/princeton-vl/CornerNet/issues/110 https://github.com/Duankaiwen/CenterNet/issues/47

zzzxxxttt commented 4 years ago

Thanks for the comment, it is now fixed in the latest commit.

songyuc commented 4 years ago

Hi, @zzzxxxttt , I notice that the current repo calculate the r3 like this: which is not divided by the 2 * a3. So, what is the reason here of calculating like this?

xuezhongcailian commented 4 years ago

same problem