Can't understand some code lines

zzzyuqing / DreamMat

[SIGGRAPH2024] DreamMat: High-quality PBR Material Generation with Geometry- and Light-aware Diffusion Models

MIT License

319 stars 13 forks source link

Can't understand some code lines #23

Open Leeepu opened 2 months ago

Leeepu commented 2 months ago

Hi，could you please tell me what these lines of code are for ？ https://github.com/zzzyuqing/DreamMat/blob/92afaa64d5fc53002701995d1f9beef8f7ba3d12/threestudio_dreammat/threestudio/models/geometry/dreammat_mesh.py#L137-L138 I can not find where these 'predictors' run.

Same trouble with the following code :

https://github.com/zzzyuqing/DreamMat/blob/92afaa64d5fc53002701995d1f9beef8f7ba3d12/threestudio_dreammat/threestudio/models/materials/dreammat_material.py#L414

zzzyuqing commented 2 months ago

It seems that those lines of code are indeed not utilized in the current implementation. You can safely disregard them for now. We appreciate your attention to detail, and we'll consider removing or refactoring these lines in a future update to clean up the codebase. If you have any further suggestions or questions, feel free to share!

Leeepu commented 2 months ago

I think so.However by my test,if I comment out these lines,the pramas would be reduced and the texture would not be as perfect as it used to be.With the frame of ThreeStudio and Lightning,I am sure these lines make sense but confused about the details. The folllowing picture shows that the material params vanish away and geometry params also be reduced by 6k.