Because we're using LOADCONF to load non-cli commands after tor has started up, whatever settings are in the torrc or torrc-defaults file are discarded anyways. In order to incorporate the torrc && torrc-defaults files in that LOADCONF call, there's a lot of parsing that'd need to occur in order to determine what should be overridden... tor already does this if you declare them in the command line arguments. I do not want to do that.....
This will make it so that all settings must be expressed in TorConfig. It also makes is so that if a setting builder is not yet implemented and someone needs it, people are SOL until that happens.
This does not change behavior between 1.x.x and 2.0.0 because LOADCONF was being used there, too.
Because we're using
LOADCONFto load non-cli commands after tor has started up, whatever settings are in thetorrcortorrc-defaultsfile are discarded anyways. In order to incorporate the torrc && torrc-defaults files in thatLOADCONFcall, there's a lot of parsing that'd need to occur in order to determine what should be overridden... tor already does this if you declare them in the command line arguments. I do not want to do that.....This will make it so that all settings must be expressed in
TorConfig. It also makes is so that if a setting builder is not yet implemented and someone needs it, people are SOL until that happens.This does not change behavior between
1.x.xand2.0.0becauseLOADCONFwas being used there, too.